Fix alerts unable to create / update when the name has trailing whitepace(s) #76079
Conversation
mikecote
added
release_note:fix
Feature:Alerting
v8.0.0
Team:ResponseOps
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
|
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
There was a problem hiding this comment.
LGTM
I don't know exactly how these api key names get used, but curious if there's some chance we'll have a migration and/or AAD issue. I'm guessing the alerting framework isn't sensitive to the "name" change, in fact I don't even think we could set the name until recently, we generally just rely on the key id. And it's only used to make the api key descriptive in the api key UI. So , I'd guess we don't have any migration concerns ...
We should be ok on this part as the alert SO remains the same. The name in the API key in Elasticsearch will now be trimmed when creating new keys. This would mean alerts can still have whitespace leading or trailing in the name (not breaking AAD / needing a migration).
The issue got introduced when the grant API key API added support for |
…pace(s) (elastic#76079) * Trim alert name in API key name * Add API integration tests
…s-for-710 * 'master' of github.com:elastic/kibana: (43 commits) [APM] Chart units don't update when toggling the chart legends (elastic#74931) [ILM] Add support for frozen phase in UI (elastic#75968) Hides advanced json for count metric (elastic#74636) add client-side feature usage API (elastic#75486) [Maps] add drilldown support map embeddable (elastic#75598) [Enterprise Search] Request handler refactors/enhancements + update existing routes to use shared handler (elastic#76106) [Resolver] model `location.search` in redux (elastic#76140) [APM] Prevent imports of public in server code (elastic#75979) fix eslint issue skip flaky suite (elastic#76223) [APM] Transaction duration anomaly alerting integration (elastic#75719) [Transforms] Avoid using "Are you sure" (elastic#75932) [Security Solution][Exceptions] - Fix bug of alerts not updating after closure from exceptions modal (elastic#76145) [plugin-helpers] improve 3rd party KP plugin support (elastic#75019) [docs/getting-started] link to yarn v1 specifically (elastic#76169) [Security_Solution][Resolver] Resolver loading and error state (elastic#75600) Fixes App Search documentation links (elastic#76133) Fix alerts unable to create / update when the name has trailing whitepace(s) (elastic#76079) [Resolver] Fix useSelector usage (elastic#76129) [Enterprise Search] Migrate util and components from ent-search (elastic#76051) ... # Conflicts: # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/data_tier_allocation/node_allocation.tsx # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/edit_policy.tsx # x-pack/plugins/index_lifecycle_management/public/application/services/policies/types.ts # x-pack/plugins/index_lifecycle_management/public/application/services/policies/warm_phase.ts
|
When this commit apply to Kibana PROD? |
|
@tatdatpham you should be able to work around this by removing any trailing spaces in the alert's name. The fix will be part of the 7.9.1 or 7.9.2 patch release. |
Resolves #76035
In this PR, I'm fixing an issue where alerts fail to be created or updated when you have trailing whitepsace(s) due to Elasticsearch's grant API key API not accepting leading and trailing whitepsace(s) in the API key's name.